Skip to content
Snippets Groups Projects
Commit 289fbdd4 authored by Jonas Höppner's avatar Jonas Höppner Committed by Tobias Kahlki
Browse files

imx8mp-ldb: remove hardcoded pixel clock overwrite

The imx8mp ldb driver had an hardcoded overwrite for the pixelclock as
the video_pll is not able to generate all needed frequencies.
But the hardcoded value only fits to one mode, probably used on the
EVK.
Removing this override leads to a pixelclock that may be generated with
a devider from the PLL, which ends up with a frquency much closer to what
is expected.

Also it is not the ldb clock but the lcdif clock used for this, so this
seems to be the wrong place for modifying the clock anyway.

BCS 746-000502

(cherry picked from commit 86df943d)
parent 86707489
No related branches found
No related tags found
2 merge requests!455CI: Update gitlab-ci,!126dts:arm64:tanaro: Add devicetree files from 5.10 kernel
......@@ -194,14 +194,26 @@ imx8mp_ldb_encoder_atomic_check(struct drm_encoder *encoder,
return -EINVAL;
}
/* Removed as the PLL might only have few PLL frequency
points, but the devider allows frequencies much closer
to the configured one, as just selecting one pixelclock
here.
If this would be needed it is also not clear
why this should be done here, as the related clock
is the lcdif*_pixel_clk on mx8mp, though I guess it should be done in
lcdifv3_crtc_atomic_check
*/
/*
* Due to limited video PLL frequency points on i.MX8mp,
* we do mode fixup here in case any mode is unsupported.
*/
/*
if (ldb->dual)
mode->clock = mode->clock > 100000 ? 148500 : 74250;
else
mode->clock = 74250;
*/
return 0;
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment