Refactoring: use join() instead of for loop

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/use-join/

scripts/.sourcery.yaml

@@ -32,7 +32,6 @@ rule_settings:
   - use-named-expression
   - use-next
   - sum-comprehension
-  - use-join
 
   rule_types:
   - refactoring

scripts/common.py

@@ -153,9 +153,10 @@ def wait_until_merge_status_is_set(project: Project, mr: MergeRequest):
 
 def list_commits(commits):
     """Create a list of commits along with the commit messages"""
-    commit_list = ""
-    for commit in commits:
-        commit_list += "\n--\n\nCommit: %s\n\n%s" % (commit.web_url, commit.message)
+    commit_list = "".join(
+        "\n--\n\nCommit: %s\n\n%s" % (commit.web_url, commit.message)
+        for commit in commits
+    )
     return commit_list
 
 

scripts/markdown_generator.py

@@ -97,9 +97,7 @@ class MarkDownTableRow:
             self._current_col += 1
 
     def __str__(self):
-        c = ""
-        for i in self.cols:
-            c += "| " + i.content + " |"
+        c = "".join("| " + i.content + " |" for i in self.cols)
         return "MarkDownTableRow (" + self.length + " cols) " + c
 
     def render(self):