diff --git a/scripts/.sourcery.yaml b/scripts/.sourcery.yaml index 049190bdb243dabbc2fd8077d340582aa9762865..54fcaeaae8a4d788eae82c8339da7317872e9d54 100644 --- a/scripts/.sourcery.yaml +++ b/scripts/.sourcery.yaml @@ -32,7 +32,6 @@ rule_settings: - use-named-expression - use-next - sum-comprehension - - use-join rule_types: - refactoring diff --git a/scripts/common.py b/scripts/common.py index a005f36dc54ef4b3fa23a5af286c134befa86434..b87a426a611392ebf03d4f76e2d16cf996c12575 100755 --- a/scripts/common.py +++ b/scripts/common.py @@ -153,9 +153,10 @@ def wait_until_merge_status_is_set(project: Project, mr: MergeRequest): def list_commits(commits): """Create a list of commits along with the commit messages""" - commit_list = "" - for commit in commits: - commit_list += "\n--\n\nCommit: %s\n\n%s" % (commit.web_url, commit.message) + commit_list = "".join( + "\n--\n\nCommit: %s\n\n%s" % (commit.web_url, commit.message) + for commit in commits + ) return commit_list diff --git a/scripts/markdown_generator.py b/scripts/markdown_generator.py index a952a501e0ef07731e467f16141530c6456aa154..9d41771f8165593c36acc10e0ccc5c7396d57655 100755 --- a/scripts/markdown_generator.py +++ b/scripts/markdown_generator.py @@ -97,9 +97,7 @@ class MarkDownTableRow: self._current_col += 1 def __str__(self): - c = "" - for i in self.cols: - c += "| " + i.content + " |" + c = "".join("| " + i.content + " |" for i in self.cols) return "MarkDownTableRow (" + self.length + " cols) " + c def render(self):