BCS 746-001531

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@17b87f84

Refactoring: remove CI_PARAM_ prefix from variables

There is no need to add a prefix to the variables. Basically every
variable can be set or overridden at the trigger level, so we just use
plain variable names for everything.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@825f3686

Refactoring: do not rename *_PATH variables in build.env

We were using different variable names for the same variable in build
and package stages. Unify these names in order to reduce potential
confusion.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@2346bb98

Refactoring: make build variable naming consistent

Use underscore to separate words within variable name.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@581541b9

Refactoring: improve FNG_INSTALL_URL definition

FNG_INSTALL_URL was defined in build.env only, and in order to use it
during the build we sourced build.env after writing it.
Remove this workaround and define the variable cleanly in the first
place. This removes the intermediate variable FNG_INSTALL_PATH.
Also move the "/artifact" path from JOB_URL to FNG_INSTALL_URL in order
to make the JOB_URL variable name match better.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@35784f29

Refactoring: improve IMAGEPATH et al. definition

On every usage of IMAGEPATH, SDKPATH and LICENSESPATH we prepended
BUILDPATH to it. Prepend it directly on definition to prevent
repetition.
Also remove redundant variable IMAGEBASEPATH.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@5e36715e

Remove needless variables from build.env

There were three variables set in build.env of which the values are
already known in the environment for all jobs, because they are passed
from the parent pipeline. Use the original variables instead of defining
new ones.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@84aa6afb

Fix LAVA job name

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@8160c7d5

Sourcery: enable "low-code-quality" check globally

Disable it locally instead, so that
 1. new code additions are always checked, and
 2. we can refactor one function at a time to make the check pass.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@ef60c378

Sourcery: keep "for-append-to-extend" check disabled

This is another check that suggests changes an average developer without
profound Python experience would find hard to understand. Disable it.

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/for-append-to-extend/

Config files generated with maXTouchStudio contain a FILE_INFO_HEADER
section that was not handled correctly by the mxt-app parser.
Add this section to the skipped sections.

If /etc/shared is located on mmcblk0boot1, the partition is read-only
per default. This prevents the SSH key generation service from working
properly.

BCS 746-001439

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@cf371aca

alphaplan_fwr: Remove obsolete pkg.py artifact

The pkg.py file is no longer deployed by the build process.

See commit
e79e8579

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@b2b43f71

Sourcery: keep "use-named-expression" check disabled

This suggestion aims to reduce code size, but IMO for the expense of
readability for non-python-experts, so we disable it.

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/use-named-expression/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@ae8c5423

Sourcery: keep "use-next" check disabled

I don't see any benefit in accepting the refactoring suggestions based
on this rule. IMO it makes the code harder to read, especially for non-
experienced Python developers.

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/use-next/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@9462f826

Refactoring: raise specific errors

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/raise-specific-error/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@61eb3e11

Switch all strings to formatted string literals (f-strings)

The old printf-style string formatting syntax using '%' is not
recommended anymore. See for reference:
https://docs.python.org/3/library/stdtypes.html#printf-style-string-formatting
https://docs.sourcery.ai/Reference/Python/Default-Rules/replace-interpolation-with-fstring/

Python 3.6 introduced f-strings as a better alternative:
https://docs.python.org/3/reference/lexical_analysis.html#f-strings

Consequently switch to this new syntax for all strings.

SC2046: Quote this to prevent word splitting.

https://www.shellcheck.net/wiki/SC2046

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@b2fb3e93

Combine build-yocto.yml and and build-common.yml to build-pipeline.yml

At the moment the output of the abs value of an input device is combined
in a 64bit value and then evaluated to detect the touch input device.
However, some shells support only 32bit int values for bitwise operations.
To fix this, the values are evaluated one after the other.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@e6808701

Add "Deploy Azure" stage

This stage contains jobs to deploy packaged artifacts to our Azure blob
storage. The required variables `AZURE_STORAGE_ACCOUNT` and
`AZURE_STORAGE_SAS_TOKEN` are stored in the GitLab CI/CD variables.
The storage container `AZURE_CONTAINER_NAME` and artifact path
`AZURE_TARGET_FOLDER` are passed from the parent pipeline.

Dmitry Petrov authored 1 year ago and Jonas Höppner committed 1 year ago

The current uuu script (uuu.lst) doesn't work for mx6 devices.

Restore previously used script and:
* make it more flexible by adding input arguments
* remove "write" commands for unused components (dtb and modules)

Also updated .bat and .sh wrappers to generate fng-boot boot script
and combined linux image (kernel + dtb).

Mikhail Vanyulin authored 1 year ago and Jonas Höppner committed 1 year ago

Signed-off-by: Mikhail Vanyulin <mikhail.vanyulin@rtsoft.de>

Mikhail Vanyulin authored 1 year ago and Jonas Höppner committed 1 year ago

Nginx logs are not rotated or controlled by Nginx itself.
Added logrotate configuration to the package.

Signed-off-by: Mikhail Vanyulin <mikhail.vanyulin@rtsoft.de>

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@f8c1d732

Add confluence stage

This adds two jobs to the Yocto pipeline:

 - generate-confluence-page
 - publish-confluence-page

The first one generates a confluence page from a template
(`confluence-page.xml.jinja2`) using information downloaded from all
successful "Deploy FTP" jobs of the same pipeline.

The second one publishes this page in Confluence and displays a link to
the new page. If the page already exists it is overwritten.

The place in Confluence where the new page is published is configurable
via the `CONFLUENCE_SPACE` and `CONFLUENCE_PARENT_ID` variables.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@fee9493b

generate-build-pipeline: re-add YAML format parsing

This was accidentally forgotten in the previous commit.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@9b777f29

Rename "generate_job_from_template" script to "render_jinja2_template"

This makes the script more general and open for other future purposes.
The parsing of the YAML content is conditional now, depending on the new
"format" argument.

It is not quite clear what parts are covered from the 'commercial' flag,
but to me it looks like, that it is related to the 'non-free' parts,
enabled with the --non-free compile switch.

The uinput package allows to filter touchscreen input via a special
device in the user-space.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@b20f6b95

Use multiple CI test pipelines

Instead of mixing dedicated CI test jobs and Yocto build simulation jobs
within one pipeline, use the new multi-build-pipelines architecture to
split them up into separate child pipelines.
This also makes most of the Yocto pipeline code reusable, so that we
don't have to declare all the jobs again in ci-test.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@f9dc2517

Rename "build jobs" to "build pipeline"

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@633c9fb4

get_pipeline_jobs: remove redundant job ID output

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@347745c5

download_job_artifacts: add error message if artifact not found

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@50f7396d

ci-test: re-enable build simulation caching

In 438f1e2aae23472d692ce6314e8c683f950657d2 we accidentally disabled
caching for the build simulation by moving the cache definition to a job
class. The order of inheritance led to the cache configuration being
overwritten by the one of the "buildbase" class. Change inheritance
order to fix this.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@30f7d966

update_submodule: fix integration branch name in case of multiple MRs

When there are multiple open merge requests for a commit, we currently
take the newest one to determine the integration branch name. This is
not necessarily the correct one, we can have an open merge request with
the commit being part of the commit history while the top commit is a
different one.

Add a check if the commit is the top commit of the merge request in
order to get the correct integration branch name in these cases.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@438f1e2a

ci-test: use more recent release for build simulation

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@1c900bf9

Update docs/add-new-project-to-pipeline.md
--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@8854fd8f

download_job_artifacts: fix temp file creation

mkstemp() returns a tuple containing an OS-level handle to an open file
(as would be returned by os.open()) and the absolute pathname of that
file, in that order.

Use higher-level function NamedTemporaryFile() instead.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@151f1cd6

Refactoring: remove redundant if

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/remove-redundant-if/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@872ec6d9

Refactoring: swap if and else branches

Move the main part of the action to the if branch.

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/swap-if-else-branches/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@c058236c

Sourcery: skip a certain suggestion for better readability

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@b9196ae5

Fix typo in comment

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@eba0649d

gitignore: add .vscode and convert line-endings to LF

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@876da56d

Refactoring: merge dictionary assignments

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/merge-dict-assign/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@e8e3ff37

Refactoring: use single assignment for "if, else"

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/assign-if-exp/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@14eaf45a

Refactoring: inline immediately returned variables

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/inline-immediately-returned-variable/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@f9096a52

Refactoring: use "{}" for creating an empty dictionary

This is the most concise and Pythonic way to create a dictionary.

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/dict-literal/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@a3baa39e

Refactoring: use list comprehensions

A list comprehension can create the list on one line, cutting out the
clutter of declaring an empty list and then appending values.

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/list-comprehension/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@52de8d7c

Refactoring: use dictionary comprehensions

A dictionary comprehension can create the dictionary on one line,
cutting out the clutter of declaring an empty dict and then adding
items.

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/dict-comprehension/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@5d09b9de

Refactoring: simplify length comparisons

Something we often do is check whether a list or sequence has elements
before we try and do something with it.

A Pythonic way of doing this is just to use the fact that Python lists
and sequences evaluate to True if they have elements, and False
otherwise.

Doing it this way is a convention, set out in Python's PEP8 style guide.

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/simplify-len-comparison/

- Removed recipes
- Removed references in the DISTRO, the files are now included via a new
  variable called MACHINE_INSTALL_SCRIPTS that is added to the
  DISTRO_INSTALL_SCRIPTS to keep the rest of the chain untouched.
  MACHINE_INSTALL_SCRIPTS is set in the machine layer if needed.

Also remove image deps to it, as it should be integrated as machine dep.
Rename to seco-sharedconf

BCS 746-001463

Delete local copy of the source code, adapt recipe to fetch it from
remote.

Install script for the mx6-boot (Flash-N-Go Boot + U-Boot) bootloader.

Original commit by Mikhail Vanyulin <mikhail.vanyulin@rtsoft.de>

BCS 746-001394

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@9406ad75

Yocto build: separate images in multiple pipelines

Instead of building the Yocto image, the Yocto SDK and the FNGSystem
image in one single pipeline, separate them into three independent
pipelines that are triggered in parallel.

This makes the concept more modular: we have a single general pipeline
now which is configurable from outside via variables. Hence we can have
a custom number of pipelines along with custom build targets in each
project without having to make code changes in the gitlab-ci project.

The default Yocto manifest pipeline configures three build pipelines:

- yocto-build-jobs
- sdk-build-jobs
- fngsystem-build-jobs

In a project including the Yocto manifest pipeline, we can disable
certain build pipelines using job rules, e.g. disabling the SDK build:

sdk-build-jobs:
  rules:
    - when: never

Furthermore we can add more pipelines by simply adding jobs extending
the '.build-jobs' class in the project's .gitlab-ci.yml:

yocto-custom-build-jobs:
  extends:
    - .build-jobs
  variables:
    BITBAKE_TASK: build
    CI_PARAM_IMAGE: custom-image
    CI_PARAM_DISTRO: custom-distro
    PACKAGE_TYPE: image

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@447804d2

.gitlab-ci: increase analyze timeout

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@5762a54c

Yocto build: unify image and SDK package jobs

Image and SDK package jobs call the same package script just with
different arguments. Instead of having two job classes `package_release`
and `package_sdk` for these two tasks, merge them into the base class
`package` and make the differences configurable via a variable
`PACKAGE_TYPE`.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@8e72eac2

Yocto build: add variable for manual builds

Instead of hard-coding the rules for manual builds in each actual job,
conditionally add this to the `buildbase` class and add a variable
`MANUAL_BUILD` to the according jobs.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@e6d71996

Yocto build: unify image and SDK build jobs

Image and SDK builds share a lot of similar code. Instead of having two
job classes `build_yocto_image` and `build_yocto_sdk` for these two
tasks, merge them into the base class `build_yocto` and make the
differences configurable via a variable.

The `dump_install_command` part of the script, which was not executed
for SDK builds, is always present now, but it's only executed if the
`INSTALLSCRIPT` variable is set, which is not the case for SDK builds.

The `collect_srcrevs` part of the script is executed in all cases. It
was not part of the SDK build before, but it's not less relevant there.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@f892500f

Yocto build: make main artifacts path configurable

Instead of specifying all possible artifacts paths and abusing the fact
that GitLab ignores non-existing paths during artifact upload, implement
a cleaner solution with a configurable path.

Add runtime dependencies and source dir.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@c227e053

Yocto build: use common artifact pathspec for image and SDK builds

This is the first step on the way to a common pipeline for all build
configurations.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@fa2766e6

README: review documentation for adding new project

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@c027f42b

README: use consistent heading style

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@f8bf107b

Sourcery: keep min-max-identity check disabled

IMO code is easier to read without the proposed change:
https://docs.sourcery.ai/Reference/Python/Default-Rules/min-max-identity/

Move the disabled check to the top of the list and add a comment that
all the checks below need to be verified.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@01484573

Refactoring: replace if-expression with or

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/or-if-exp-identity/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@ccdac3d5

Sourcery: enable more passing checks

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@d5908ee5

Refactoring: remove needless str() from print()

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/remove-str-from-print/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@479861fb

Sourcery: enable passing checks

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@7c87d4d1

Sourcery: skip use-assigned-variable

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@26591c0b

Refactoring: use datetime.now() instead of datetime.today()

now() is officially preferred over today() according to the docs.
See for reference:

https://docs.sourcery.ai/Reference/Python/Default-Rules/use-datetime-now-not-today/
https://docs.python.org/3/library/datetime.html#datetime.datetime.now

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@414ebe6d

Add python code analysis via sourcery

Disable all checks which do not pass currently. These should be enabled
in the future along with a code refactoring to make them pass.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@df817ecf

README: Add howto to create a new project.

The package depends on gbm which is not supported for seco-mx6-fsl
machine. See commit 4420f4fa ("qtbase: Remove gbm packageconfig_distro
option for seco-mx6-fsl machine").

Also the package depends on libavcodec provided by ffmpeg. It requires
to accept the commercial license. The following line should be added to
local.conf:
LICENSE_FLAGS_ACCEPTED = "commercial_ffmpeg"

Tobias Kahlki authored 2 years ago and Felix Gerking committed 1 year ago

The Medium Quality Sound (MQS) interface on the Nallino was patched to reduce
unwanted noise during audio playback. The service triggers some initialization
routines in the audio stack by playing a silent sine wave.

Original commit by Sam Crossman <sam.crossman@seco.com>

BCS 746-001388

(cherry picked from commit b10ff5b8)

BCS 746-001397

The used redirection was not POSIX compliant.

With the layer upgrade there seem to be some build problems and we do
not really need this variant currently.

If the --files-on-target flag is set, the partition where the installation
files are stored remains mounted during the installation. The partition
from which to install cannot be a target partition for the installation.
Since the partition table cannot be changed safely, the --reuse-partition
option is implied.

BCS 746-001239

The return code from the awk script was used in two if cases with "$?",
but the value in $? is set to the result of the first '[]' command in
the first if.
Fixed this by storing the result in a seperate variable.

BCS 746-001371

Until now we only update the rotation in the weston.ini based on the
fbcon rotation from the kernel command line during installation/1st
boot.
This service updates it during each boot.

Set rotation of ts_calibrate according to the value from fbcon.

BCS 746-001371

BCS 746-001371

If the transform for the internal display doesn't match the rotation of
the fbcon, the service fixes the weston.ini.

BCS 746-001371

Changed from simple to notify, so that the service blocks dependencies
until it has run successfully.