Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
gitlab-ci
Manage
Activity
Members
Labels
Plan
Jira
Code
Merge requests
5
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Analyze
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
SECO Northern Europe
Yocto
infrastructure
gitlab-ci
Merge requests
!69
accept_merge_request: refactoring
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
accept_merge_request: refactoring
accept-mr-refactoring
into
master
Overview
0
Commits
1
Pipelines
1
Changes
1
Merged
Tobias Kahlki
requested to merge
accept-mr-refactoring
into
master
3 years ago
Overview
0
Commits
1
Pipelines
1
Changes
1
Expand
Combine two return statements into one.
Switch if statement order to remove else branch.
0
0
Merge request reports
Compare
master
master (base)
and
latest version
latest version
79e3437d
1 commit,
3 years ago
1 file
+
8
−
10
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
accept_merge_request.py
+
8
−
10
Options
@@ -44,10 +44,9 @@ def accept_merge_request(project, mr, rebase=False):
else
:
if
mr
.
merge_error
:
print
(
"
Merge error: %s
"
%
mr
.
merge_error
)
return
False
else
:
print
(
"
Merge reported success, but MR state is
'
%s
'"
%
mr
.
state
)
return
False
return
False
except
GitlabMRClosedError
as
e
:
# See HTTP error codes for merge requests here:
@@ -80,15 +79,14 @@ def accept_merge_request(project, mr, rebase=False):
print
(
""
)
pipeline_pending
=
False
print
(
"
Merge not possible, but branch can be automatically rebased
"
)
if
rebase
:
print
(
"
Trying to rebase...
"
)
mr
=
common
.
rebase_merge_request
(
project
,
mr
)
if
mr
.
merge_error
:
print
(
"
ERROR: rebase not possible
\n
'
%s
'"
%
mr
.
merge_error
)
sys
.
exit
(
critical_error
)
print
(
"
Sucessfully rebased
"
)
else
:
if
not
rebase
:
return
False
print
(
"
Trying to rebase...
"
)
mr
=
common
.
rebase_merge_request
(
project
,
mr
)
if
mr
.
merge_error
:
print
(
"
ERROR: rebase not possible
\n
'
%s
'"
%
mr
.
merge_error
)
sys
.
exit
(
critical_error
)
print
(
"
Sucessfully rebased
"
)
else
:
if
pipeline_pending
:
Loading