common: use uppercase for constants

scripts/accept_merge_request.py

@@ -72,7 +72,7 @@ def accept_merge_request(project, mr, rebase=False, should_remove_source_branch=
                     # No pipeline created yet
                     print("No pipeline created yet")
                     time.sleep(1)
-                elif mr.head_pipeline["status"] in common.pending_states:
+                elif mr.head_pipeline["status"] in common.PENDING_STATES:
                     # Pipeline pending
                     if not pipeline_pending:
                         print("Waiting for pending pipeline", end="", flush=True)

scripts/common.py

@@ -13,9 +13,9 @@ from gitlab.v4.objects import Project
 from gitlab.v4.objects import MergeRequest
 
 
-manifest_file = "default.xml"
-srcrev_file = "SRCREV.conf"
-pending_states = ["created", "waiting_for_resource", "preparing", "pending", "running"]
+MANIFEST_FILE = "default.xml"
+SRCREV_FILE = "SRCREV.conf"
+PENDING_STATES = ["created", "waiting_for_resource", "preparing", "pending", "running"]
 
 
 def integration_branch_name(project_name, source_branch_name, target_branch_name):

scripts/deploy_gitlab_ci.py

@@ -162,14 +162,14 @@ def main():
         "--manifest-file",
         help="""manifest file name (default: 'default.xml')""",
         dest="manifest_file",
-        default=common.manifest_file,
+        default=common.MANIFEST_FILE,
         required=False,
     )
     parser.add_argument(
         "--srcrev-file",
         help="""source revision file name (default: 'SRCREV.conf')""",
         dest="srcrev_file",
-        default=common.srcrev_file,
+        default=common.SRCREV_FILE,
         required=False,
     )
     parser.add_argument(

scripts/get_current_revision_from_manifest.py

@@ -15,7 +15,7 @@ def get_current_revision_from_manifest(
     manifest_branch,
     project: Project,
     recipe_name=None,
-    srcrev_file=common.srcrev_file,
+    srcrev_file=common.SRCREV_FILE,
 ):
     """
     Reads the xml manifest an the SRC_REVC file in the given manifest project
@@ -114,7 +114,7 @@ def main():
         "--srcrev-file",
         help="""source revision file name (default: 'SRCREV.conf')""",
         dest="srcrev_file",
-        default=common.srcrev_file,
+        default=common.SRCREV_FILE,
         required=False,
     )
     parser.add_argument(

scripts/integrate_into_manifest.py

@@ -219,14 +219,14 @@ def main():
         "--manifest-file",
         help="""manifest file name (default: 'default.xml')""",
         dest="manifest_file",
-        default=common.manifest_file,
+        default=common.MANIFEST_FILE,
         required=False,
     )
     parser.add_argument(
         "--srcrev-file",
         help="""source revision file name (default: 'SRCREV.conf')""",
         dest="srcrev_file",
-        default=common.srcrev_file,
+        default=common.SRCREV_FILE,
         required=False,
     )
     parser.add_argument(

scripts/merge_into_manifest.py

@@ -96,7 +96,7 @@ def merge_into_manifest(
             manifest_revision = integrate_into_manifest(
                 manifest_project=manifest_project,
                 manifest_branch=target_branch,
-                manifest_file=common.manifest_file,
+                manifest_file=common.MANIFEST_FILE,
                 srcrev_file=srcrev_file,
                 recipe_name=recipe_name,
                 project=project,
@@ -161,7 +161,7 @@ def main():
         "--srcrev-file",
         help="""source revision file name (default: 'SRCREV.conf')""",
         dest="srcrev_file",
-        default=common.srcrev_file,
+        default=common.SRCREV_FILE,
         required=False,
     )
     parser.add_argument(