Integrate gitlab-ci/improve-variable-naming and 8 more
Compare changes
Commit: seco-ne/yocto/infrastructure/gitlab-ci@17b87f84
Refactoring: remove CI_PARAM_ prefix from variables
There is no need to add a prefix to the variables. Basically every variable can be set or overridden at the trigger level, so we just use plain variable names for everything.
--
Commit: seco-ne/yocto/infrastructure/gitlab-ci@825f3686
Refactoring: do not rename *_PATH variables in build.env
We were using different variable names for the same variable in build and package stages. Unify these names in order to reduce potential confusion.
--
Commit: seco-ne/yocto/infrastructure/gitlab-ci@2346bb98
Refactoring: make build variable naming consistent
Use underscore to separate words within variable name.
--
Commit: seco-ne/yocto/infrastructure/gitlab-ci@581541b9
Refactoring: improve FNG_INSTALL_URL definition
FNG_INSTALL_URL was defined in build.env only, and in order to use it during the build we sourced build.env after writing it. Remove this workaround and define the variable cleanly in the first place. This removes the intermediate variable FNG_INSTALL_PATH. Also move the "/artifact" path from JOB_URL to FNG_INSTALL_URL in order to make the JOB_URL variable name match better.
--
Commit: seco-ne/yocto/infrastructure/gitlab-ci@35784f29
Refactoring: improve IMAGEPATH et al. definition
On every usage of IMAGEPATH, SDKPATH and LICENSESPATH we prepended BUILDPATH to it. Prepend it directly on definition to prevent repetition. Also remove redundant variable IMAGEBASEPATH.
--
Commit: seco-ne/yocto/infrastructure/gitlab-ci@5e36715e
Remove needless variables from build.env
There were three variables set in build.env of which the values are already known in the environment for all jobs, because they are passed from the parent pipeline. Use the original variables instead of defining new ones.
--
Commit: seco-ne/yocto/infrastructure/gitlab-ci@84aa6afb
Fix LAVA job name
--
Commit: seco-ne/yocto/infrastructure/gitlab-ci@8160c7d5
Sourcery: enable "low-code-quality" check globally
Disable it locally instead, so that
--
Commit: seco-ne/yocto/infrastructure/gitlab-ci@ef60c378
Sourcery: keep "for-append-to-extend" check disabled
This is another check that suggests changes an average developer without profound Python experience would find hard to understand. Disable it.
See for reference: https://docs.sourcery.ai/Reference/Python/Default-Rules/for-append-to-extend/