--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@cdd47023

Introduce separate variables to set RELEASE_NAME and RELEASE_VERSION

The expressions to calculate RELEASE_NAME and RELEASE_VERSION cannot be
stored within these variables themseselves. If set on the trigger level,
they would override the calculated values in build-version.env then,
as trigger variables always have the highest precedence.

Use separate variables RELEASE_VERSION_EXPRESSION and
RELEASE_NAME_EXPRESSION to define how RELEASE_VERSION and RELEASE_NAME
are calculated instead.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@372d192b

Use RELEASE_VERSION and RELEASE_NAME from build-version job

Instead of passing these variables from stage to stage or regenerating
their values in later stages, use the ones set in the build-version job
at all places.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@cad30c20

Remove RELEASE_SUFFIX variable

The RELEASE_NAME variable can be set directly now, so there's no need to
have a dedicated RELEASE_SUFFIX anymore. A previous configuration like

  RELEASE_SUFFIX: "-custom"

can now be achieved using:

  RELEASE_NAME: "Yocto-${RELEASE_VERSION}-custom"

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@922f49f8

Add yocto version job

This adds a machine-independent job "build-version" which populates the
RELEASE_VERSION and RELEASE_NAME variables, so that following jobs can
use these without depending on the various build jobs.
The variables can be set from the trigger job in a project's
`.gitlab-ci.yml` file. They are eval'ed before saving them to
version.env, so we can use deferred variable expansion or even command
execution to construct their values. This mechanism is already used for
the Flash-N-Go System variables.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@073ae81e

LAVA: rename MACHINE to LAVA_MACHINE

Rename variable in order to avoid confusion with the original MACHINE
variable used everywhere else. Also rename the local Jinja2 variable to
include an underscore to make naming consistent.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@a91baa55

Clean build.env before writing

This had been accidentally removed in
5e36715ef6cf98df4c1b98fedddc0c3c50ed4040.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@1860ca8e

Remove LOG_PREFIX variable

This was used in times when the same code was executed from different
places. We don't do that anymore, so the variable is obsolete.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@3d2dbe4d

Documentation: update job generation chapter

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@17b87f84

Refactoring: remove CI_PARAM_ prefix from variables

There is no need to add a prefix to the variables. Basically every
variable can be set or overridden at the trigger level, so we just use
plain variable names for everything.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@825f3686

Refactoring: do not rename *_PATH variables in build.env

We were using different variable names for the same variable in build
and package stages. Unify these names in order to reduce potential
confusion.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@2346bb98

Refactoring: make build variable naming consistent

Use underscore to separate words within variable name.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@581541b9

Refactoring: improve FNG_INSTALL_URL definition

FNG_INSTALL_URL was defined in build.env only, and in order to use it
during the build we sourced build.env after writing it.
Remove this workaround and define the variable cleanly in the first
place. This removes the intermediate variable FNG_INSTALL_PATH.
Also move the "/artifact" path from JOB_URL to FNG_INSTALL_URL in order
to make the JOB_URL variable name match better.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@35784f29

Refactoring: improve IMAGEPATH et al. definition

On every usage of IMAGEPATH, SDKPATH and LICENSESPATH we prepended
BUILDPATH to it. Prepend it directly on definition to prevent
repetition.
Also remove redundant variable IMAGEBASEPATH.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@5e36715e

Remove needless variables from build.env

There were three variables set in build.env of which the values are
already known in the environment for all jobs, because they are passed
from the parent pipeline. Use the original variables instead of defining
new ones.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@84aa6afb

Fix LAVA job name

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@8160c7d5

Sourcery: enable "low-code-quality" check globally

Disable it locally instead, so that
 1. new code additions are always checked, and
 2. we can refactor one function at a time to make the check pass.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@ef60c378

Sourcery: keep "for-append-to-extend" check disabled

This is another check that suggests changes an average developer without
profound Python experience would find hard to understand. Disable it.

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/for-append-to-extend/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@cf371aca

alphaplan_fwr: Remove obsolete pkg.py artifact

The pkg.py file is no longer deployed by the build process.

See commit
seco-ne/yocto/layers/meta-seconorth-distro@e79e8579

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@b2b43f71

Sourcery: keep "use-named-expression" check disabled

This suggestion aims to reduce code size, but IMO for the expense of
readability for non-python-experts, so we disable it.

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/use-named-expression/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@ae8c5423

Sourcery: keep "use-next" check disabled

I don't see any benefit in accepting the refactoring suggestions based
on this rule. IMO it makes the code harder to read, especially for non-
experienced Python developers.

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/use-next/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@9462f826

Refactoring: raise specific errors

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/raise-specific-error/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@61eb3e11

Switch all strings to formatted string literals (f-strings)

The old printf-style string formatting syntax using '%' is not
recommended anymore. See for reference:
https://docs.python.org/3/library/stdtypes.html#printf-style-string-formatting
https://docs.sourcery.ai/Reference/Python/Default-Rules/replace-interpolation-with-fstring/

Python 3.6 introduced f-strings as a better alternative:
https://docs.python.org/3/reference/lexical_analysis.html#f-strings

Consequently switch to this new syntax for all strings.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@b2fb3e93

Combine build-yocto.yml and and build-common.yml to build-pipeline.yml