--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@b20f6b95

Use multiple CI test pipelines

Instead of mixing dedicated CI test jobs and Yocto build simulation jobs
within one pipeline, use the new multi-build-pipelines architecture to
split them up into separate child pipelines.
This also makes most of the Yocto pipeline code reusable, so that we
don't have to declare all the jobs again in ci-test.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@f9dc2517

Rename "build jobs" to "build pipeline"

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@633c9fb4

get_pipeline_jobs: remove redundant job ID output

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@347745c5

download_job_artifacts: add error message if artifact not found

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@50f7396d

ci-test: re-enable build simulation caching

In 438f1e2aae23472d692ce6314e8c683f950657d2 we accidentally disabled
caching for the build simulation by moving the cache definition to a job
class. The order of inheritance led to the cache configuration being
overwritten by the one of the "buildbase" class. Change inheritance
order to fix this.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@30f7d966

update_submodule: fix integration branch name in case of multiple MRs

When there are multiple open merge requests for a commit, we currently
take the newest one to determine the integration branch name. This is
not necessarily the correct one, we can have an open merge request with
the commit being part of the commit history while the top commit is a
different one.

Add a check if the commit is the top commit of the merge request in
order to get the correct integration branch name in these cases.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@438f1e2a

ci-test: use more recent release for build simulation

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@1c900bf9

Update docs/add-new-project-to-pipeline.md
--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@8854fd8f

download_job_artifacts: fix temp file creation

mkstemp() returns a tuple containing an OS-level handle to an open file
(as would be returned by os.open()) and the absolute pathname of that
file, in that order.

Use higher-level function NamedTemporaryFile() instead.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@151f1cd6

Refactoring: remove redundant if

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/remove-redundant-if/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@872ec6d9

Refactoring: swap if and else branches

Move the main part of the action to the if branch.

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/swap-if-else-branches/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@c058236c

Sourcery: skip a certain suggestion for better readability

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@b9196ae5

Fix typo in comment

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@eba0649d

gitignore: add .vscode and convert line-endings to LF

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@876da56d

Refactoring: merge dictionary assignments

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/merge-dict-assign/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@e8e3ff37

Refactoring: use single assignment for "if, else"

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/assign-if-exp/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@14eaf45a

Refactoring: inline immediately returned variables

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/inline-immediately-returned-variable/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@f9096a52

Refactoring: use "{}" for creating an empty dictionary

This is the most concise and Pythonic way to create a dictionary.

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/dict-literal/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@a3baa39e

Refactoring: use list comprehensions

A list comprehension can create the list on one line, cutting out the
clutter of declaring an empty list and then appending values.

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/list-comprehension/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@52de8d7c

Refactoring: use dictionary comprehensions

A dictionary comprehension can create the dictionary on one line,
cutting out the clutter of declaring an empty dict and then adding
items.

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/dict-comprehension/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@5d09b9de

Refactoring: simplify length comparisons

Something we often do is check whether a list or sequence has elements
before we try and do something with it.

A Pythonic way of doing this is just to use the fact that Python lists
and sequences evaluate to True if they have elements, and False
otherwise.

Doing it this way is a convention, set out in Python's PEP8 style guide.

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/simplify-len-comparison/

Add code to generate the "serial" property in DT overlay.
It contains the last 3 bytes of MAC address combined into one integer.

By analogy with MAC address we need to apply it to a base dtb
so that serial number remains the same from the first boot.

A new command is available in U-Boot to parse an XML configuration
file and generate a device tree overlay (dto).

The code is based on "gfxml2dto" tool
(https://git.seco.com/seco-ne/tools/gfxml2dto).

Signed-off-by: Mikhail Vanyulin <mikhail.vanyulin@rtsoft.de>

Bootcounter and switch partitions functionality was not ported with original
sysdata copy from u-boot-seco-imx.
Added corresponding code to bootm and booti commands and to board_r.c.

Signed-off-by: Mikhail Vanyulin <mikhail.vanyulin@rtsoft.de>

Signed-off-by: Mikhail Vanyulin <mikhail.vanyulin@rtsoft.de>

Env is planned to be taken from user partition of eMMC.
Disabled CONFIG_ENV_IS_IN_FAT and enabled CONFIG_ENV_IS_IN_MMC.
Updated env offset to match edgehog boards.

Signed-off-by: Mikhail Vanyulin <mikhail.vanyulin@rtsoft.de>

Set mmc env device to 0, to match new mmc order.
Set env offset ot 0xc0000 to mathc edgehog settings.

Signed-off-by: Mikhail Vanyulin <mikhail.vanyulin@rtsoft.de>

Signed-off-by: Mikhail Vanyulin <mikhail.vanyulin@rtsoft.de>

eMMC is now mmc dev 0.
SD - 1.

Signed-off-by: Mikhail Vanyulin <mikhail.vanyulin@rtsoft.de>

mmc_get_boot_dev return a base boot dev number. In case of eMMC it is 3.
This happens even after mmc order will be changed via aliases.
To workaround this, always use following code for seco-mx6 target:
env_get_ulong("mmcdev", 10, CONFIG_SYS_MMC_ENV_DEV)

Signed-off-by: Mikhail Vanyulin <mikhail.vanyulin@rtsoft.de>

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@9406ad75

Yocto build: separate images in multiple pipelines

Instead of building the Yocto image, the Yocto SDK and the FNGSystem
image in one single pipeline, separate them into three independent
pipelines that are triggered in parallel.

This makes the concept more modular: we have a single general pipeline
now which is configurable from outside via variables. Hence we can have
a custom number of pipelines along with custom build targets in each
project without having to make code changes in the gitlab-ci project.

The default Yocto manifest pipeline configures three build pipelines:

- yocto-build-jobs
- sdk-build-jobs
- fngsystem-build-jobs

In a project including the Yocto manifest pipeline, we can disable
certain build pipelines using job rules, e.g. disabling the SDK build:

sdk-build-jobs:
  rules:
    - when: never

Furthermore we can add more pipelines by simply adding jobs extending
the '.build-jobs' class in the project's .gitlab-ci.yml:

yocto-custom-build-jobs:
  extends:
    - .build-jobs
  variables:
    BITBAKE_TASK: build
    CI_PARAM_IMAGE: custom-image
    CI_PARAM_DISTRO: custom-distro
    PACKAGE_TYPE: image

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@447804d2

.gitlab-ci: increase analyze timeout

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@5762a54c

Yocto build: unify image and SDK package jobs

Image and SDK package jobs call the same package script just with
different arguments. Instead of having two job classes `package_release`
and `package_sdk` for these two tasks, merge them into the base class
`package` and make the differences configurable via a variable
`PACKAGE_TYPE`.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@8e72eac2

Yocto build: add variable for manual builds

Instead of hard-coding the rules for manual builds in each actual job,
conditionally add this to the `buildbase` class and add a variable
`MANUAL_BUILD` to the according jobs.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@e6d71996

Yocto build: unify image and SDK build jobs

Image and SDK builds share a lot of similar code. Instead of having two
job classes `build_yocto_image` and `build_yocto_sdk` for these two
tasks, merge them into the base class `build_yocto` and make the
differences configurable via a variable.

The `dump_install_command` part of the script, which was not executed
for SDK builds, is always present now, but it's only executed if the
`INSTALLSCRIPT` variable is set, which is not the case for SDK builds.

The `collect_srcrevs` part of the script is executed in all cases. It
was not part of the SDK build before, but it's not less relevant there.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@f892500f

Yocto build: make main artifacts path configurable

Instead of specifying all possible artifacts paths and abusing the fact
that GitLab ignores non-existing paths during artifact upload, implement
a cleaner solution with a configurable path.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@c227e053

Yocto build: use common artifact pathspec for image and SDK builds

This is the first step on the way to a common pipeline for all build
configurations.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@fa2766e6

README: review documentation for adding new project

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@c027f42b

README: use consistent heading style

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@f8bf107b

Sourcery: keep min-max-identity check disabled

IMO code is easier to read without the proposed change:
https://docs.sourcery.ai/Reference/Python/Default-Rules/min-max-identity/

Move the disabled check to the top of the list and add a comment that
all the checks below need to be verified.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@01484573

Refactoring: replace if-expression with or

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/or-if-exp-identity/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@ccdac3d5

Sourcery: enable more passing checks

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@d5908ee5

Refactoring: remove needless str() from print()

See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/remove-str-from-print/

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@479861fb

Sourcery: enable passing checks

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@7c87d4d1

Sourcery: skip use-assigned-variable

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@26591c0b

Refactoring: use datetime.now() instead of datetime.today()

now() is officially preferred over today() according to the docs.
See for reference:

https://docs.sourcery.ai/Reference/Python/Default-Rules/use-datetime-now-not-today/
https://docs.python.org/3/library/datetime.html#datetime.datetime.now

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@414ebe6d

Add python code analysis via sourcery

Disable all checks which do not pass currently. These should be enabled
in the future along with a code refactoring to make them pass.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@df817ecf

README: Add howto to create a new project.

Add a common function to export the current temperature grade as
environment var. The var should later be evaluated by bootscript to
set the appropriate temperature limits in the devicetree.
Enabled the temp grade export for imx8m platforms.

BCS 746-001385

Dmitry Petrov authored 1 year ago and Jonas Höppner committed 1 year ago

The 'pbb' board needs different settings, so these are applied depending
on the board detection.

BCS 746-001402

Dmitry Petrov authored 1 year ago and Jonas Höppner committed 1 year ago

The current implementation of board detection calls gpio_lookup_name() which
is not available in SPL:

    aarch64-seconorth-linux-ld.bfd: board/keithkoep/common/built-in.o: in function `baseboard_get_gpio_value':
    uboot-imx-kuk/board/keithkoep/common/baseboard_util.c:20: undefined reference to `gpio_lookup_name'
    make[1]: *** [scripts/Makefile.spl:420: spl/u-boot-spl] Error 1
    make: *** [Makefile:1865: spl/u-boot-spl] Error 2

The existing GPIO names are just simple numbers coded as strings (i.e. expanded
IMX_GPIO_NR macro):

    #define PFID_SOM_MARKER_PIN     "109"
    ...
    // SBC imx6
    #define PFID_SBC_IMX6_VERSION_BIT0    "37"
    ...
    // SBC imx8m Mini
    #define PFID_SBC_IMX8MM_VERSION_BIT0    "89"
    ...
    // SBC imx8m Plus
    #define PFID_SBC_IMX8MP_VERSION_BIT0    "102"
    ...
    // SOM imx8m
    #define PFID_SOM_VERSION_BIT0   "113"
    ...

The easiest way to fix baseboard_get_gpio_value() routine in SPL is replace
gpio_lookup_name() call with simple_strtol().
This should work if we will follow this naming convention in future.

During initial board preparation sys_proto.h was lost.
This will fix following warning during compilation:

board/keithkoep/seco_mx6/seco_mx6.c: In function ‘dram_init’:
board/keithkoep/seco_mx6/seco_mx6.c:45:24: warning: implicit declaration of function ‘imx_ddr_size’ [-Wimplicit-function-declaration]
   45 |         gd->ram_size = imx_ddr_size();

Signed-off-by: Mikhail Vanyulin <mikhail.vanyulin@rtsoft.de>

Signed-off-by: Mikhail Vanyulin <mikhail.vanyulin@rtsoft.de>

Signed-off-by: Mikhail Vanyulin <mikhail.vanyulin@rtsoft.de>

Signed-off-by: Mikhail Vanyulin <mikhail.vanyulin@rtsoft.de>

It was enabled for other boards.

Signed-off-by: Mikhail Vanyulin <mikhail.vanyulin@rtsoft.de>

Mikhail Vanyulin authored 1 year ago and Jonas Höppner committed 1 year ago

Signed-off-by: Mikhail Vanyulin <mikhail.vanyulin@rtsoft.de>

Mikhail Vanyulin authored 1 year ago and Jonas Höppner committed 1 year ago

Fuse description differs between imx6 and imx8.
Compilation for imx6 fails with following error:
board/keithkoep/common/kuk_boards.c: In function ‘kuk_GetOTP’:
board/keithkoep/common/kuk_boards.c:105:22: error: ‘struct fuse_bank1_regs’ has no member named ‘cfg0’
  105 |         switch( fuse1->cfg0 & 0x7000)

Signed-off-by: Mikhail Vanyulin <mikhail.vanyulin@rtsoft.de>

Mikhail Vanyulin authored 1 year ago and Jonas Höppner committed 1 year ago

It will be used to support all imx6 SAN boards.

Signed-off-by: Mikhail Vanyulin <mikhail.vanyulin@rtsoft.de>

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@31e5a427

CI: package: Increase timeout to 90

We had timeouts during the upload of the artifacts
so I increase it to 90 minutes.

BCS 746-001370

This u-boot command looks for a set of known environment variables
containing module, board and u-boot version and installs their values
into the /version node in the device tree.

Martin Oemus authored 1 year ago and Tobias Kahlki committed 1 year ago

This results in U-Boot setting the envrionment variable "ver" to the
values of its PLAIN_VERSION symbol

Martin Oemus authored 1 year ago and Tobias Kahlki committed 1 year ago

This commit uses the new baseboard detection to make the descriptive
output during boot ("This is a...") more meaningful.

Martin Oemus authored 1 year ago and Tobias Kahlki committed 1 year ago

This commit removes all code which was previously used to detect the
board, as this functionality was moved to
board/keithkoep/common/baseboard*. Only code with the purpose to do the
bootmode detection remains.

Martin Oemus authored 1 year ago and Tobias Kahlki committed 1 year ago

This commit implements generic platform and baseboard revision detection
for SBC and SOM systems. It currently supports PFID based baseboard
detection.

- baseboard.h: common interface to query baseboard type and revision. It
  defines the board types, detects whether PFIDs are used or some other
  system and forwards the calls to the proper implementation.
- baseboard_pfids.h: type and revision detection using PFIDs
- baseboard_util.h: utility functions for reading GPIO values

Some additional functions were made available in kuk_boards.h to
implement the changes.

Martin Oemus authored 1 year ago and Martin Oemus committed 1 year ago

This change is required to make the fdt apply u-boot command available
which is used for applying device tree overlays.

--

Commit: seco-ne/yocto/infrastructure/gitlab-ci@23680f48

Fix check for branch protection state

Since the changes of 939ade2b9f98b3e1569332270a7ab16ce7d70b4a we observe
that pipelines are executed on non-protected branches, which is not what
we want.

GitLab's documentation was a bit unclear on the according CI variables
CI_COMMIT_REF_PROTECTED and CI_MERGE_REQUEST_TARGET_BRANCH_PROTECTED, as
stated in this stack overflow answer:
https://stackoverflow.com/a/59023344/3018229

We need to explicitly check for the variable values to be "true" instead
of just checking whether they are set.