Skip to content
Snippets Groups Projects
  1. May 12, 2012
  2. May 11, 2012
  3. Apr 28, 2012
  4. Apr 27, 2012
  5. Apr 26, 2012
    • Oliver Neukum's avatar
      USB: cdc-wdm: fix race leading leading to memory corruption · 5c22837a
      Oliver Neukum authored
      
      This patch fixes a race whereby a pointer to a buffer
      would be overwritten while the buffer was in use leading
      to a double free and a memory leak. This causes crashes.
      This bug was introduced in 2.6.34
      
      Signed-off-by: default avatarOliver Neukum <oneukum@suse.de>
      Tested-by: default avatarBjørn Mork <bjorn@mork.no>
      Cc: stable <stable@vger.kernel.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      5c22837a
    • Stefano Stabellini's avatar
      xen: use the pirq number to check the pirq_eoi_map · 521394e4
      Stefano Stabellini authored
      
      In pirq_check_eoi_map use the pirq number rather than the Linux irq
      number to check whether an eoi is needed in the pirq_eoi_map.
      
      The reason is that the irq number is not always identical to the
      pirq number so if we wrongly use the irq number to check the
      pirq_eoi_map we are going to check for the wrong pirq to EOI.
      
      As a consequence some interrupts might not be EOI'ed by the
      guest correctly.
      
      Signed-off-by: default avatarStefano Stabellini <stefano.stabellini@eu.citrix.com>
      Tested-by: default avatarTobias Geiger <tobias.geiger@vido.info>
      [v1: Added some extra wording to git commit]
      Signed-off-by: default avatarKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
      521394e4
    • Rupesh Gujare's avatar
    • Paul Gortmaker's avatar
      blackfin: fix compile error in bfin-lq035q1-fb.c · bc856a62
      Paul Gortmaker authored
      
      This file has an implicit dependency on GPIO stuff, showing
      up as the following build failure:
      
      drivers/video/bfin-lq035q1-fb.c:369:6: error: 'GPIOF_OUT_INIT_LOW' undeclared
      
      Other more global bfin build issues prevent an automated bisect, but
      it really doesn't matter - simply add in the appropriate header.
      
      Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
      Acked-by: default avatarMike Frysinger <vapier@gentoo.org>
      Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
      bc856a62
    • Paul Gortmaker's avatar
      pci: frv architecture needs generic setup-bus infrastructure · cd0a2bfb
      Paul Gortmaker authored
      
      Otherwise we get this link failure for frv's defconfig:
      
         LD      .tmp_vmlinux1
       drivers/built-in.o: In function `pci_assign_resource':
       (.text+0xbf0c): undefined reference to `pci_cardbus_resource_alignment'
       drivers/built-in.o: In function `pci_setup':
       pci.c:(.init.text+0x174): undefined reference to `pci_realloc_get_opt'
       pci.c:(.init.text+0x1a0): undefined reference to `pci_realloc_get_opt'
       make[1]: *** [.tmp_vmlinux1] Error 1
      
      Cc: David Howells <dhowells@redhat.com>
      Acked-by: default avatarBjorn Helgaas <bhelgaas@google.com>
      Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
      cd0a2bfb
    • Daniel Vetter's avatar
      drm/i915: handle input/output sdvo timings separately in mode_set · 6651819b
      Daniel Vetter authored
      
      We seem to have a decent confusion between the output timings and the
      input timings of the sdvo encoder. If I understand the code correctly,
      we use the original mode unchanged for the output timings, safe for
      the lvds case. And we should use the adjusted mode for input timings.
      
      Clarify the situation by adding an explicit output_dtd to the sdvo
      mode_set function and streamline the code-flow by moving the input and
      output mode setting in the sdvo encode together.
      
      Furthermore testing showed that the sdvo input timing needs the
      unadjusted dotclock, the sdvo chip will automatically compute the
      required pixel multiplier to get a dotclock above 100 MHz.
      
      Fix this up when converting a drm mode to an sdvo dtd.
      
      This regression was introduced in
      
      commit c74696b9
      Author: Pavel Roskin <proski@gnu.org>
      Date:   Thu Sep 2 14:46:34 2010 -0400
      
          i915: revert some checks added by commit 32aad86f
      
      particularly the following hunk:
      
      diff --git a/drivers/gpu/drm/i915/intel_sdvo.c
      b/drivers/gpu/drm/i915/intel_sdvo.c
      index 093e914..62d22ae 100644
      --- a/drivers/gpu/drm/i915/intel_sdvo.c
      +++ b/drivers/gpu/drm/i915/intel_sdvo.c
      @@ -1122,11 +1123,9 @@ static void intel_sdvo_mode_set(struct drm_encoder *encoder,
      
           /* We have tried to get input timing in mode_fixup, and filled into
              adjusted_mode */
      -    if (intel_sdvo->is_tv || intel_sdvo->is_lvds) {
      -        intel_sdvo_get_dtd_from_mode(&input_dtd, adjusted_mode);
      +    intel_sdvo_get_dtd_from_mode(&input_dtd, adjusted_mode);
      +    if (intel_sdvo->is_tv || intel_sdvo->is_lvds)
               input_dtd.part2.sdvo_flags = intel_sdvo->sdvo_flags;
      -    } else
      -        intel_sdvo_get_dtd_from_mode(&input_dtd, mode);
      
           /* If it's a TV, we already set the output timing in mode_fixup.
            * Otherwise, the output timing is equal to the input timing.
      
      Due to questions raised in review, below a more elaborate analysis of
      the bug at hand:
      
      Sdvo seems to have two timings, one is the output timing which will be
      sent over whatever is connected on the other side of the sdvo chip (panel,
      hdmi screen, tv), the other is the input timing which will be generated by
      the gmch pipe. It looks like sdvo is expected to scale between the two.
      
      To make things slightly more complicated, we have a bunch of special
      cases:
      - For lvds panel we always use a fixed output timing, namely
        intel_sdvo->sdvo_lvds_fixed_mode, hence that special case.
      - Sdvo has an interface to generate a preferred input timing for a given
        output timing. This is the confusing thing that I've tried to clear up
        with the follow-on patches.
      - A special requirement is that the input pixel clock needs to be between
        100MHz and 200MHz (likely to keep it within the electromechanical design
        range of PCIe), 270MHz on later gen4+. Lower pixel clocks are
        doubled/quadrupled.
      
      The thing this patch tries to fix is that the pipe needs to be
      explicitly instructed to double/quadruple the pixels and needs the
      correspondingly higher pixel clock, whereas the sdvo adaptor seems to
      do that itself and needs the unadjusted pixel clock. For the sdvo
      encode side we already set the pixel mutliplier with a different
      command (0x21).
      
      This patch tries to fix this mess by:
      - Keeping the output mode timing in the unadjusted plain mode, safe
        for the lvds case.
      - Storing the input timing in the adjusted_mode with the adjusted
        pixel clock. This way we don't need to frob around with the core
        crtc mode set code.
      - Fixing up the pixelclock when constructing the sdvo dtd timing
        struct. This is why the first hunk of the patch is an integral part
        of the series.
      - Dropping the is_tv special case because input_dtd is equivalent to
        adjusted_mode after these changes. Follow-up patches clear this up
        further (by simply ripping out intel_sdvo->input_dtd because it's
        not needed).
      
      v2: Extend commit message with an in-depth bug analysis.
      
      Reported-and-Tested-by: default avatarBernard Blackham <b-linuxgit@largestprime.net>
      Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=48157
      
      
      Reviewed-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
      Cc: stable@kernel.org
      Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
      6651819b
    • Guenter Roeck's avatar
      hwmon: (fam15h_power) Fix pci_device_id array · c3e40a99
      Guenter Roeck authored
      
      pci_match_id() takes an *array* of IDs which must be properly zero-
      terminated.
      
      Reported-by: default avatarBen Hutchings <ben@decadent.org.uk>
      Cc: stable@vger.kernel.org # 3.0+: 00250ec9 hwmon: fam15h_power: fix bogus values
      Cc: stable@vger.kernel.org # 3.0+
      Signed-off-by: default avatarGuenter Roeck <guenter.roeck@ericsson.com>
      Acked-by: default avatarJean Delvare <khali@linux-fr.org>
      c3e40a99
    • Mingarelli, Thomas's avatar
      hpwdt: Only BYTE reads/writes to WD Timer port 0x72 · d08c9a33
      Mingarelli, Thomas authored
      
      This patch is to correct the use of the iLO port 0x72 usage.
      The port 0x72 is a byte size write/read and hpwdt is currently
      writing a WORD.
      
      Signed-off by: Thomas Mingarelli <thomas.mingarelli@hp.com>
      Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
      d08c9a33
    • Anatolij Gustschin's avatar
      drivers/rtc/rtc-ds1307.c: fix BUG shown with lock debugging enabled · 3f5ec5e0
      Anatolij Gustschin authored
      
      Add struct bin_attribute initialization to fix the following bug:
      
      rtc-ds1307 3-0068: rtc core: registered ds1307 as rtc0
      BUG: key cfb14fcc not in .data!
      ------------[ cut here ]------------
      WARNING: at kernel/lockdep.c:2986 sysfs_add_file_mode+0x84/0xdc()
      Modules linked in:
      [<c0018d94>] (unwind_backtrace+0x0/0xf8) from [<c0031f7c>] (warn_slowpath_common+0x4c/0x64)
      [<c0031f7c>] (warn_slowpath_common+0x4c/0x64) from [<c0031fb0>] (warn_slowpath_null+0x1c/0x24)
      [<c0031fb0>] (warn_slowpath_null+0x1c/0x24) from [<c012f7ac>] (sysfs_add_file_mode+0x84/0xdc)
      [<c012f7ac>] (sysfs_add_file_mode+0x84/0xdc) from [<c04b11e4>] (ds1307_probe+0x5e4/0x6ac)
      [<c04b11e4>] (ds1307_probe+0x5e4/0x6ac) from [<c036e600>] (i2c_device_probe+0xdc/0x108)
      [<c036e600>] (i2c_device_probe+0xdc/0x108) from [<c02cdf84>] (driver_probe_device+0x90/0x210)
      [<c02cdf84>] (driver_probe_device+0x90/0x210) from [<c02ce198>] (__driver_attach+0x94/0x98)
      [<c02ce198>] (__driver_attach+0x94/0x98) from [<c02cc824>] (bus_for_each_dev+0x50/0x7c)
      [<c02cc824>] (bus_for_each_dev+0x50/0x7c) from [<c02cd780>] (bus_add_driver+0x184/0x244)
      [<c02cd780>] (bus_add_driver+0x184/0x244) from [<c02ce43c>] (driver_register+0x78/0x12c)
      [<c02ce43c>] (driver_register+0x78/0x12c) from [<c03701ac>] (i2c_register_driver+0x2c/0xb4)
      [<c03701ac>] (i2c_register_driver+0x2c/0xb4) from [<c0008798>] (do_one_initcall+0x34/0x178)
      [<c0008798>] (do_one_initcall+0x34/0x178) from [<c0691860>] (kernel_init+0xdc/0x194)
      [<c0691860>] (kernel_init+0xdc/0x194) from [<c0013cf0>] (kernel_thread_exit+0x0/0x8)
      
      Since commit 6992f533 ("sysfs: Use one lockdep class per sysfs
      attribute") this initialization is required.
      
      Reported-by: default avatarStefano Babic <sbabic@denx.de>
      Tested-by: default avatarStefano Babic <sbabic@denx.de>
      Signed-off-by: default avatarAnatolij Gustschin <agust@denx.de>
      Cc: Alessandro Zummo <a.zummo@towertech.it>
      Cc: Stefano Babic <sbabic@denx.de>
      Cc: Eric W. Biederman <ebiederm@xmission.com>
      Cc: Greg Kroah-Hartman <gregkh@suse.de>
      Acked-by: default avatarWolfram Sang <w.sang@pengutronix.de>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      3f5ec5e0
    • Peter Feuerer's avatar
      acerhdf: lowered default temp fanon/fanoff values · 351963bb
      Peter Feuerer authored
      
      Due to new supported hardware, of which the actual temperature limits of
      processor, harddisk and other components are unknown, it feels safer with
      lower fanon / fanoff settings.
      
      It won't change much for most people, already using acerhdf, as they use
      their own fanon/fanoff variable settings when loading the module.
      
      Furthermore seems like kernel and userspace tools have been improved to
      work more efficient and netbooks don't get so hot anymore.
      
      Signed-off-by: default avatarPeter Feuerer <peter@piie.net>
      Acked-by: default avatarBorislav Petkov <petkovbb@gmail.com>
      Cc: Matthew Garrett <mjg@redhat.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      351963bb
    • Peter Feuerer's avatar
      acerhdf: add support for new hardware · 43ae1e32
      Peter Feuerer authored
      
      Add support for new hardware:
      Acer Aspire LT-10Q/531/751/1810/1825,
      Acer Travelmate 7730,
      Packard Bell ENBFT/DOTVR46
      
      Signed-off-by: default avatarPeter Feuerer <peter@piie.net>
      Acked-by: default avatarBorislav Petkov <petkovbb@gmail.com>
      Cc: Matthew Garrett <mjg@redhat.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      43ae1e32
    • Clay Carpenter's avatar
      acerhdf: add support for Aspire 1410 BIOS v1.3314 · e39a9ba2
      Clay Carpenter authored
      
      Add support for Aspire 1410 BIOS v1.3314.  Fixes the following error:
      
      acerhdf: unknown (unsupported) BIOS version Acer/Aspire 1410/v1.3314,
      please report, aborting!
      
      Signed-off-by: default avatarClay Carpenter <claycarpenter@gmail.com>
      Signed-off-by: default avatarPeter Feuerer <peter@piie.net>
      Cc: Matthew Garrett <mjg@redhat.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      e39a9ba2
  6. Apr 25, 2012
  7. Apr 24, 2012
Loading