[media] au0828: Fix dev_state handling
The au0828 dev_state is actually a bit mask. It should not be checking with "==" but, instead, with a logic and. There are some places where it was doing it wrong. Fix that by replacing the dev_state set/clear/test with the bitops. As reviewed by Shuah: "Looks good. Tested running bind/unbind au0828 loop for 1000 times. Didn't see any problems and the v4l2_querycap() problem has been fixed with this patch. After the above test, ran bind/unbind snd_usb_audio 1000 times. Didn't see any problems. Generated media graph and the graph looks good." Cc: stable@vger.kernel.org Reviewed-by:Shuah Khan <shuahkh@osg.samsung.com> Tested-by:
Shuah Khan <shuahkh@osg.samsung.com> Signed-off-by:
Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Showing
- drivers/media/usb/au0828/au0828-core.c 1 addition, 1 deletiondrivers/media/usb/au0828/au0828-core.c
- drivers/media/usb/au0828/au0828-input.c 2 additions, 2 deletionsdrivers/media/usb/au0828/au0828-input.c
- drivers/media/usb/au0828/au0828-video.c 31 additions, 32 deletionsdrivers/media/usb/au0828/au0828-video.c
- drivers/media/usb/au0828/au0828.h 5 additions, 4 deletionsdrivers/media/usb/au0828/au0828.h
Loading
Please register or sign in to comment