Skip to content
Snippets Groups Projects
Commit cd2f1a54 authored by Teresa Remmet's avatar Teresa Remmet Committed by Gianfranco Mariotti
Browse files

i2c: imx: Remove clk_get_rate for each transfer again

As clk_get_rate() also keeps the clk prepare lock which can lead into a
deadlock. It was removed upstream with this commit:
(90ad2cbe) i2c: imx: use clk notifier for rate changes

But it has been readded again with:
(d2561688) MLK-20368 i2c-imx: Coverity: fix divide by zero warning

The commit message does not explain why it was readded. It is not needed
as the clk notifier is used. Removed it again.

REFERENCE: https://github.com/nxp-imx/linux-imx/pull/21
parent 985e047f
No related branches found
No related tags found
1 merge request!208Draft: i2c: imx: Fix deadlock issues
......@@ -705,10 +705,6 @@ static int i2c_imx_start(struct imx_i2c_struct *i2c_imx, bool atomic)
dev_dbg(&i2c_imx->adapter.dev, "<%s>\n", __func__);
result = i2c_imx_set_clk(i2c_imx, clk_get_rate(i2c_imx->clk));
if (result)
return result;
imx_i2c_write_reg(i2c_imx->ifdr, i2c_imx, IMX_I2C_IFDR);
/* Enable I2C controller */
imx_i2c_write_reg(i2c_imx->hwdata->i2sr_clr_opcode, i2c_imx, IMX_I2C_I2SR);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment