Skip to content
Snippets Groups Projects
Commit ccfc5693 authored by Petr Machata's avatar Petr Machata Committed by David S. Miller
Browse files

mlxsw: spectrum_flower: Do not stop at FLOW_ACTION_VLAN_MANGLE


The handler for FLOW_ACTION_VLAN_MANGLE ends by returning whatever the
lower-level function that it calls returns. If there are more actions lined
up after this action, those are never offloaded. Fix by only bailing out
when the called function returns an error.

Fixes: a150201a ("mlxsw: spectrum: Add support for vlan modify TC action")
Signed-off-by: default avatarPetr Machata <petrm@mellanox.com>
Reviewed-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0be0ae14
No related branches found
No related tags found
No related merge requests found
...@@ -150,9 +150,12 @@ static int mlxsw_sp_flower_parse_actions(struct mlxsw_sp *mlxsw_sp, ...@@ -150,9 +150,12 @@ static int mlxsw_sp_flower_parse_actions(struct mlxsw_sp *mlxsw_sp,
u8 prio = act->vlan.prio; u8 prio = act->vlan.prio;
u16 vid = act->vlan.vid; u16 vid = act->vlan.vid;
return mlxsw_sp_acl_rulei_act_vlan(mlxsw_sp, rulei, err = mlxsw_sp_acl_rulei_act_vlan(mlxsw_sp, rulei,
act->id, vid, act->id, vid,
proto, prio, extack); proto, prio, extack);
if (err)
return err;
break;
} }
case FLOW_ACTION_PRIORITY: case FLOW_ACTION_PRIORITY:
err = mlxsw_sp_acl_rulei_act_priority(mlxsw_sp, rulei, err = mlxsw_sp_acl_rulei_act_priority(mlxsw_sp, rulei,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment