Skip to content
Snippets Groups Projects
Commit c59d342d authored by Horia Geantă's avatar Horia Geantă
Browse files

crypto: caam - lower SM test verbosity


Let's use dev_dbg() instead of dev_info() to minimize verbosity in case
we're not interested in low-level details.

While here, replace dev_info() with dev_err() in places where errors are
reported.

Reported-by: default avatarAbel Vesa <abel.vesa@nxp.com>
Signed-off-by: default avatarHoria Geantă <horia.geanta@nxp.com>
parent 0b42acc8
No related branches found
No related tags found
No related merge requests found
...@@ -74,12 +74,12 @@ static void key_display(struct device *dev, u8 *label, u16 size, u8 *key) ...@@ -74,12 +74,12 @@ static void key_display(struct device *dev, u8 *label, u16 size, u8 *key)
{ {
unsigned i; unsigned i;
dev_info(dev, label); dev_dbg(dev, label);
for (i = 0; i < size; i += 8) for (i = 0; i < size; i += 8)
dev_info(dev, dev_dbg(dev,
"[%04d] %02x %02x %02x %02x %02x %02x %02x %02x\n", "[%04d] %02x %02x %02x %02x %02x %02x %02x %02x\n",
i, key[i], key[i + 1], key[i + 2], key[i + 3], i, key[i], key[i + 1], key[i + 2], key[i + 3],
key[i + 4], key[i + 5], key[i + 6], key[i + 7]); key[i + 4], key[i + 5], key[i + 6], key[i + 7]);
} }
int caam_sm_example_init(struct platform_device *pdev) int caam_sm_example_init(struct platform_device *pdev)
...@@ -308,25 +308,25 @@ int caam_sm_example_init(struct platform_device *pdev) ...@@ -308,25 +308,25 @@ int caam_sm_example_init(struct platform_device *pdev)
if (sm_keystore_slot_export(ksdev, unit, keyslot8, BLACK_KEY, if (sm_keystore_slot_export(ksdev, unit, keyslot8, BLACK_KEY,
KEY_COVER_ECB, blob8, 8, skeymod)) { KEY_COVER_ECB, blob8, 8, skeymod)) {
dev_info(ksdev, "blkkey_ex: can't encapsulate 64-bit key\n"); dev_err(ksdev, "blkkey_ex: can't encapsulate 64-bit key\n");
goto dealloc; goto dealloc;
} }
if (sm_keystore_slot_export(ksdev, unit, keyslot16, BLACK_KEY, if (sm_keystore_slot_export(ksdev, unit, keyslot16, BLACK_KEY,
KEY_COVER_ECB, blob16, 16, skeymod)) { KEY_COVER_ECB, blob16, 16, skeymod)) {
dev_info(ksdev, "blkkey_ex: can't encapsulate 128-bit key\n"); dev_err(ksdev, "blkkey_ex: can't encapsulate 128-bit key\n");
goto dealloc; goto dealloc;
} }
if (sm_keystore_slot_export(ksdev, unit, keyslot24, BLACK_KEY, if (sm_keystore_slot_export(ksdev, unit, keyslot24, BLACK_KEY,
KEY_COVER_ECB, blob24, 24, skeymod)) { KEY_COVER_ECB, blob24, 24, skeymod)) {
dev_info(ksdev, "blkkey_ex: can't encapsulate 192-bit key\n"); dev_err(ksdev, "blkkey_ex: can't encapsulate 192-bit key\n");
goto dealloc; goto dealloc;
} }
if (sm_keystore_slot_export(ksdev, unit, keyslot32, BLACK_KEY, if (sm_keystore_slot_export(ksdev, unit, keyslot32, BLACK_KEY,
KEY_COVER_ECB, blob32, 32, skeymod)) { KEY_COVER_ECB, blob32, 32, skeymod)) {
dev_info(ksdev, "blkkey_ex: can't encapsulate 256-bit key\n"); dev_err(ksdev, "blkkey_ex: can't encapsulate 256-bit key\n");
goto dealloc; goto dealloc;
} }
...@@ -345,25 +345,25 @@ int caam_sm_example_init(struct platform_device *pdev) ...@@ -345,25 +345,25 @@ int caam_sm_example_init(struct platform_device *pdev)
*/ */
if (sm_keystore_slot_import(ksdev, unit, keyslot8, BLACK_KEY, if (sm_keystore_slot_import(ksdev, unit, keyslot8, BLACK_KEY,
KEY_COVER_ECB, blob8, 8, skeymod)) { KEY_COVER_ECB, blob8, 8, skeymod)) {
dev_info(ksdev, "blkkey_ex: can't decapsulate 64-bit blob\n"); dev_err(ksdev, "blkkey_ex: can't decapsulate 64-bit blob\n");
goto dealloc; goto dealloc;
} }
if (sm_keystore_slot_import(ksdev, unit, keyslot16, BLACK_KEY, if (sm_keystore_slot_import(ksdev, unit, keyslot16, BLACK_KEY,
KEY_COVER_ECB, blob16, 16, skeymod)) { KEY_COVER_ECB, blob16, 16, skeymod)) {
dev_info(ksdev, "blkkey_ex: can't decapsulate 128-bit blob\n"); dev_err(ksdev, "blkkey_ex: can't decapsulate 128-bit blob\n");
goto dealloc; goto dealloc;
} }
if (sm_keystore_slot_import(ksdev, unit, keyslot24, BLACK_KEY, if (sm_keystore_slot_import(ksdev, unit, keyslot24, BLACK_KEY,
KEY_COVER_ECB, blob24, 24, skeymod)) { KEY_COVER_ECB, blob24, 24, skeymod)) {
dev_info(ksdev, "blkkey_ex: can't decapsulate 196-bit blob\n"); dev_err(ksdev, "blkkey_ex: can't decapsulate 196-bit blob\n");
goto dealloc; goto dealloc;
} }
if (sm_keystore_slot_import(ksdev, unit, keyslot32, BLACK_KEY, if (sm_keystore_slot_import(ksdev, unit, keyslot32, BLACK_KEY,
KEY_COVER_ECB, blob32, 32, skeymod)) { KEY_COVER_ECB, blob32, 32, skeymod)) {
dev_info(ksdev, "blkkey_ex: can't decapsulate 256-bit blob\n"); dev_err(ksdev, "blkkey_ex: can't decapsulate 256-bit blob\n");
goto dealloc; goto dealloc;
} }
...@@ -374,29 +374,29 @@ int caam_sm_example_init(struct platform_device *pdev) ...@@ -374,29 +374,29 @@ int caam_sm_example_init(struct platform_device *pdev)
*/ */
if (sm_keystore_slot_read(ksdev, unit, keyslot8, AES_BLOCK_PAD(8), if (sm_keystore_slot_read(ksdev, unit, keyslot8, AES_BLOCK_PAD(8),
rstkey8)) { rstkey8)) {
dev_info(ksdev, dev_err(ksdev,
"blkkey_ex: can't read restored 64-bit black key\n"); "blkkey_ex: can't read restored 64-bit black key\n");
goto dealloc; goto dealloc;
} }
if (sm_keystore_slot_read(ksdev, unit, keyslot16, AES_BLOCK_PAD(16), if (sm_keystore_slot_read(ksdev, unit, keyslot16, AES_BLOCK_PAD(16),
rstkey16)) { rstkey16)) {
dev_info(ksdev, dev_err(ksdev,
"blkkey_ex: can't read restored 128-bit black key\n"); "blkkey_ex: can't read restored 128-bit black key\n");
goto dealloc; goto dealloc;
} }
if (sm_keystore_slot_read(ksdev, unit, keyslot24, AES_BLOCK_PAD(24), if (sm_keystore_slot_read(ksdev, unit, keyslot24, AES_BLOCK_PAD(24),
rstkey24)) { rstkey24)) {
dev_info(ksdev, dev_err(ksdev,
"blkkey_ex: can't read restored 196-bit black key\n"); "blkkey_ex: can't read restored 196-bit black key\n");
goto dealloc; goto dealloc;
} }
if (sm_keystore_slot_read(ksdev, unit, keyslot32, AES_BLOCK_PAD(32), if (sm_keystore_slot_read(ksdev, unit, keyslot32, AES_BLOCK_PAD(32),
rstkey32)) { rstkey32)) {
dev_info(ksdev, dev_err(ksdev,
"blkkey_ex: can't read restored 256-bit black key\n"); "blkkey_ex: can't read restored 256-bit black key\n");
goto dealloc; goto dealloc;
} }
...@@ -423,18 +423,18 @@ int caam_sm_example_init(struct platform_device *pdev) ...@@ -423,18 +423,18 @@ int caam_sm_example_init(struct platform_device *pdev)
*/ */
if (memcmp(rstkey16, blkkey16, AES_BLOCK_PAD(16))) { if (memcmp(rstkey16, blkkey16, AES_BLOCK_PAD(16))) {
dev_info(ksdev, "blkkey_ex: 128-bit restored key mismatch\n"); dev_err(ksdev, "blkkey_ex: 128-bit restored key mismatch\n");
rtnval--; rtnval--;
} }
/* Only first AES block will match, remainder subject to padding */ /* Only first AES block will match, remainder subject to padding */
if (memcmp(rstkey24, blkkey24, 16)) { if (memcmp(rstkey24, blkkey24, 16)) {
dev_info(ksdev, "blkkey_ex: 192-bit restored key mismatch\n"); dev_err(ksdev, "blkkey_ex: 192-bit restored key mismatch\n");
rtnval--; rtnval--;
} }
if (memcmp(rstkey32, blkkey32, AES_BLOCK_PAD(32))) { if (memcmp(rstkey32, blkkey32, AES_BLOCK_PAD(32))) {
dev_info(ksdev, "blkkey_ex: 256-bit restored key mismatch\n"); dev_err(ksdev, "blkkey_ex: 256-bit restored key mismatch\n");
rtnval--; rtnval--;
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment