Skip to content
Snippets Groups Projects
Commit bb046fef authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Greg Kroah-Hartman
Browse files

staging: panel: register reboot


we donot need the reboot notifier in module init section, as the
notifier is used after lcd is initialized. so lets register for the
reboot notifier only after we have successfully attached to the
parallel port. and similarly unregister at detach.

Signed-off-by: default avatarSudip Mukherjee <sudip@vectorindia.org>
Acked-by: default avatarWilly Tarreau <w@1wt.eu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent de99befd
No related branches found
No related tags found
No related merge requests found
......@@ -2234,6 +2234,7 @@ static void panel_attach(struct parport *port)
if (misc_register(&keypad_dev))
goto err_lcd_unreg;
}
register_reboot_notifier(&panel_notifier);
return;
err_lcd_unreg:
......@@ -2255,6 +2256,8 @@ static void panel_detach(struct parport *port)
return;
}
unregister_reboot_notifier(&panel_notifier);
if (keypad.enabled && keypad_initialized) {
misc_deregister(&keypad_dev);
keypad_initialized = 0;
......@@ -2321,7 +2324,6 @@ static int __init panel_init_module(void)
break;
}
/*
* Overwrite selection with module param values (both keypad and lcd),
* where the deprecated params have lower prio.
......@@ -2391,8 +2393,6 @@ static int __init panel_init_module(void)
return -EIO;
}
register_reboot_notifier(&panel_notifier);
if (pprt)
pr_info("driver version " PANEL_VERSION
" registered on parport%d (io=0x%lx).\n", parport,
......@@ -2408,7 +2408,6 @@ static int __init panel_init_module(void)
static void __exit panel_cleanup_module(void)
{
unregister_reboot_notifier(&panel_notifier);
if (scan_timer.function != NULL)
del_timer_sync(&scan_timer);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment