LSM: Introduce kernel_post_load_data() hook
There are a few places in the kernel where LSMs would like to have visibility into the contents of a kernel buffer that has been loaded or read. While security_kernel_post_read_file() (which includes the buffer) exists as a pairing for security_kernel_read_file(), no such hook exists to pair with security_kernel_load_data(). Earlier proposals for just using security_kernel_post_read_file() with a NULL file argument were rejected (i.e. "file" should always be valid for the security_..._file hooks, but it appears at least one case was left in the kernel during earlier refactoring. (This will be fixed in a subsequent patch.) Since not all cases of security_kernel_load_data() can have a single contiguous buffer made available to the LSM hook (e.g. kexec image segments are separately loaded), there needs to be a way for the LSM to reason about its expectations of the hook coverage. In order to handle this, add a "contents" argument to the "kernel_load_data" hook that indicates if the newly added "kernel_post_load_data" hook will be called with the full contents once loaded. That way, LSMs requiring full contents can choose to unilaterally reject "kernel_load_data" with contents=false (which is effectively the existing hook coverage), but when contents=true they can allow it and later evaluate the "kernel_post_load_data" hook once the buffer is loaded. With this change, LSMs can gain coverage over non-file-backed data loads (e.g. init_module(2) and firmware userspace helper), which will happen in subsequent patches. Additionally prepare IMA to start processing these cases. Signed-off-by:Kees Cook <keescook@chromium.org> Reviewed-by:
KP Singh <kpsingh@google.com> Link: https://lore.kernel.org/r/20201002173828.2099543-9-keescook@chromium.org Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Showing
- drivers/base/firmware_loader/fallback.c 1 addition, 1 deletiondrivers/base/firmware_loader/fallback.c
- drivers/base/firmware_loader/fallback_platform.c 1 addition, 1 deletiondrivers/base/firmware_loader/fallback_platform.c
- include/linux/ima.h 11 additions, 2 deletionsinclude/linux/ima.h
- include/linux/lsm_hook_defs.h 3 additions, 1 deletioninclude/linux/lsm_hook_defs.h
- include/linux/lsm_hooks.h 10 additions, 0 deletionsinclude/linux/lsm_hooks.h
- include/linux/security.h 12 additions, 2 deletionsinclude/linux/security.h
- kernel/kexec.c 1 addition, 1 deletionkernel/kexec.c
- kernel/module.c 1 addition, 1 deletionkernel/module.c
- security/integrity/ima/ima_main.c 23 additions, 1 deletionsecurity/integrity/ima/ima_main.c
- security/loadpin/loadpin.c 1 addition, 1 deletionsecurity/loadpin/loadpin.c
- security/security.c 17 additions, 3 deletionssecurity/security.c
- security/selinux/hooks.c 1 addition, 1 deletionsecurity/selinux/hooks.c
Loading
Please register or sign in to comment