efi_pstore: Add a sequence counter to a variable name
[Issue] Currently, a variable name, which identifies each entry, consists of type, id and ctime. But if multiple events happens in a short time, a second/third event may fail to log because efi_pstore can't distinguish each event with current variable name. [Solution] A reasonable way to identify all events precisely is introducing a sequence counter to the variable name. The sequence counter has already supported in a pstore layer with "oopscount". So, this patch adds it to a variable name. Also, it is passed to read/erase callbacks of platform drivers in accordance with the modification of the variable name. <before applying this patch> a variable name of first event: dump-type0-1-12345678 a variable name of second event: dump-type0-1-12345678 type:0 id:1 ctime:12345678 If multiple events happen in a short time, efi_pstore can't distinguish them because variable names are same among them. <after applying this patch> it can be distinguishable by adding a sequence counter as follows. a variable name of first event: dump-type0-1-1-12345678 a variable name of Second event: dump-type0-1-2-12345678 type:0 id:1 sequence counter: 1(first event), 2(second event) ctime:12345678 In case of a write callback executed in pstore_console_write(), "0" is added to an argument of the write callback because it just logs all kernel messages and doesn't need to care about multiple events. Signed-off-by:Seiji Aguchi <seiji.aguchi@hds.com> Acked-by:
Rafael J. Wysocki <rafael.j.wysocki@intel.com> Acked-by:
Mike Waychison <mikew@google.com> Signed-off-by:
Tony Luck <tony.luck@intel.com>
Showing
- drivers/acpi/apei/erst.c 6 additions, 6 deletionsdrivers/acpi/apei/erst.c
- drivers/firmware/efivars.c 14 additions, 9 deletionsdrivers/firmware/efivars.c
- fs/pstore/inode.c 5 additions, 3 deletionsfs/pstore/inode.c
- fs/pstore/internal.h 1 addition, 1 deletionfs/pstore/internal.h
- fs/pstore/platform.c 7 additions, 6 deletionsfs/pstore/platform.c
- fs/pstore/ram.c 3 additions, 4 deletionsfs/pstore/ram.c
- include/linux/pstore.h 5 additions, 3 deletionsinclude/linux/pstore.h
Loading
Please register or sign in to comment