package_release: refactoring

Improve readability of package_release.py and its submodule generate_release_metadata.py.

• Add describing comments throughout the file.
• Remove duplicate code from functions. Simplify them, so that they do what their names say (and nothing more).
• Rename variables and function arguments to make their purpose clearer.
• Harmonize variable names with their corresponding command line arguments.
• Add pydoc for functions.
• Add type declarations to function arguments.
• Generate MD5 and metadata files in the source directories so that they can be copied along with the rest of the files.
• Make output-dir an argument that can be passed multiple times instead of hard-coding two dirs with certain meanings.
• Remove LOCALDIR variable from package.env, because it is not used anywhere (only occurence was job class ".uploadsdkftp" which wasn't used anywhere either).

scripts/package_release.py

@@ -66,13 +66,6 @@ def main():
         help="""Yocto licenses directory""",
         dest="licenses_dir",
     )
-    parser.add_argument(
-        "--output-dir",
-        help="""Base directory name for output artifacts (can be specified multiple times)""",
-        dest="output_dir",
-        action="append",
-        required=True,
-    )
     parser.add_argument(
         "--sdk-dir",
         help="""Yocto sdk directory""",
@@ -83,6 +76,13 @@ def main():
         help="""Documentation directory""",
         dest="doc_dir",
     )
+    parser.add_argument(
+        "--output-dir",
+        help="""Base directory name for output artifacts (can be specified multiple times)""",
+        dest="output_dir",
+        action="append",
+        required=True,
+    )
     args, _ = parser.parse_known_args()
 
     # Get bitbake variables from testdata.json file