From f9096a522c07f50b12e07e7c6a6560c9f7911c15 Mon Sep 17 00:00:00 2001
From: Tim Jaacks <tim.jaacks@seco.com>
Date: Mon, 31 Jul 2023 11:58:47 +0200
Subject: [PATCH] Refactoring: use "{}" for creating an empty dictionary
This is the most concise and Pythonic way to create a dictionary.
See for reference:
https://docs.sourcery.ai/Reference/Python/Default-Rules/dict-literal/
---
scripts/.sourcery.yaml | 1 -
scripts/generate_release_metadata.py | 12 ++++++------
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/scripts/.sourcery.yaml b/scripts/.sourcery.yaml
index a03b9ac8..d5d2043b 100644
--- a/scripts/.sourcery.yaml
+++ b/scripts/.sourcery.yaml
@@ -20,7 +20,6 @@ rule_settings:
- inline-immediately-returned-variable
- remove-redundant-if
- switch
- - dict-literal
- low-code-quality
- for-append-to-extend
- raise-specific-error
diff --git a/scripts/generate_release_metadata.py b/scripts/generate_release_metadata.py
index cb601147..40deea60 100755
--- a/scripts/generate_release_metadata.py
+++ b/scripts/generate_release_metadata.py
@@ -31,7 +31,7 @@ def generate_metadata(
elif filename.endswith(machine + ".wic"):
image_wic = filename
- metadata = dict()
+ metadata = {}
metadata["files"] = []
metadata["version"] = version
@@ -39,31 +39,31 @@ def generate_metadata(
metadata["date"] = datetime.now().strftime("%Y-%m-%d")
if install_script is not None:
- new_file = dict()
+ new_file = {}
new_file["name"] = "Install Script"
new_file["path"] = install_script
metadata["files"].append(new_file)
if image_general is not None:
- new_file = dict()
+ new_file = {}
new_file["name"] = "Image"
new_file["path"] = image_general
metadata["files"].append(new_file)
if image_wic is not None:
- new_file = dict()
+ new_file = {}
new_file["name"] = "SD-Card Image (WIC)"
new_file["path"] = image_wic
metadata["files"].append(new_file)
if sdk is not None:
- new_file = dict()
+ new_file = {}
new_file["name"] = "SDK"
new_file["path"] = "sdk/" + sdk + ".sh"
metadata["files"].append(new_file)
if licenses is not None:
- new_file = dict()
+ new_file = {}
new_file["name"] = "Licenses"
new_file["path"] = licenses
metadata["files"].append(new_file)
--
GitLab