From f8bf107b6b2fbd85cd2dc3846ee1f361f6578a3c Mon Sep 17 00:00:00 2001 From: Tim Jaacks <tim.jaacks@seco.com> Date: Fri, 21 Jul 2023 10:39:49 +0200 Subject: [PATCH] Sourcery: keep min-max-identity check disabled IMO code is easier to read without the proposed change: https://docs.sourcery.ai/Reference/Python/Default-Rules/min-max-identity/ Move the disabled check to the top of the list and add a comment that all the checks below need to be verified. --- scripts/.sourcery.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/.sourcery.yaml b/scripts/.sourcery.yaml index 80da2482..dfa86fb8 100644 --- a/scripts/.sourcery.yaml +++ b/scripts/.sourcery.yaml @@ -6,6 +6,10 @@ rule_settings: - default disable: + # Code is easier to read without this + - min-max-identity + # FIXME: verify if we want to keep the checks below. + # If not, remove them. If yes, move them above this comment. - use-fstring-for-formatting - replace-interpolation-with-fstring - use-fstring-for-concatenation @@ -31,7 +35,6 @@ rule_settings: - use-join - merge-comparisons - merge-else-if-into-elif - - min-max-identity rule_types: - refactoring -- GitLab