From ef60c37843caf1e8c53bae8efb267ef155bbfc65 Mon Sep 17 00:00:00 2001 From: Tim Jaacks <tim.jaacks@seco.com> Date: Tue, 29 Aug 2023 08:53:59 +0200 Subject: [PATCH] Sourcery: keep "for-append-to-extend" check disabled This is another check that suggests changes an average developer without profound Python experience would find hard to understand. Disable it. See for reference: https://docs.sourcery.ai/Reference/Python/Default-Rules/for-append-to-extend/ --- scripts/.sourcery.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/.sourcery.yaml b/scripts/.sourcery.yaml index 3a3eb0f8..bb1bbfd0 100644 --- a/scripts/.sourcery.yaml +++ b/scripts/.sourcery.yaml @@ -6,6 +6,8 @@ rule_settings: - default disable: + # Might make the code more pythonic, but takes more time to understand + - for-append-to-extend # Code is easier to read without this - min-max-identity # Keep explicit lower range limit instead of using implicit default value @@ -17,7 +19,6 @@ rule_settings: # FIXME: verify if we want to keep the checks below. # If not, remove them. If yes, move them above this comment. - low-code-quality - - for-append-to-extend rule_types: - refactoring -- GitLab