From ae8c5423959057ff0288355122d73d3669704d97 Mon Sep 17 00:00:00 2001 From: Tim Jaacks <tim.jaacks@seco.com> Date: Mon, 28 Aug 2023 14:44:27 +0200 Subject: [PATCH] Sourcery: keep "use-next" check disabled I don't see any benefit in accepting the refactoring suggestions based on this rule. IMO it makes the code harder to read, especially for non- experienced Python developers. See for reference: https://docs.sourcery.ai/Reference/Python/Default-Rules/use-next/ --- scripts/.sourcery.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/.sourcery.yaml b/scripts/.sourcery.yaml index be823ea9..e84ee339 100644 --- a/scripts/.sourcery.yaml +++ b/scripts/.sourcery.yaml @@ -10,12 +10,13 @@ rule_settings: - min-max-identity # Keep explicit lower range limit instead of using implicit default value - remove-zero-from-range + # Requires special Python knowlege that not everyone reading the code might have + - use-next # FIXME: verify if we want to keep the checks below. # If not, remove them. If yes, move them above this comment. - low-code-quality - for-append-to-extend - use-named-expression - - use-next rule_types: - refactoring -- GitLab