From 0ec55c07a3398c13af5aefdaacb02ca0bf5c4142 Mon Sep 17 00:00:00 2001 From: Tim Jaacks <tim.jaacks@seco.com> Date: Thu, 19 Oct 2023 10:41:36 +0200 Subject: [PATCH] Fix list() call in update_submodule Here we don't just iterate over the results, so we have to use "all=True" instead of "as_list=False". See previous commit for explaination. --- scripts/update_submodule.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/update_submodule.py b/scripts/update_submodule.py index 032dec31..4b77ca13 100755 --- a/scripts/update_submodule.py +++ b/scripts/update_submodule.py @@ -233,7 +233,7 @@ def update_submodule_and_include_ref( # Get commits between current and new revision revision_range = f"{submodule_current_rev}..{new_revision}" commits = submodule_project.commits.list( - ref_name=revision_range, as_list=False, retry_transient_errors=True + ref_name=revision_range, all=True, retry_transient_errors=True ) if not commits: logging.info( -- GitLab