From c397722e86c0d9fd20170da73b78d21bc671341c Mon Sep 17 00:00:00 2001 From: Shengjiu Wang <shengjiu.wang@nxp.com> Date: Thu, 26 Aug 2021 10:53:51 +0800 Subject: [PATCH] LF-4484: remoteproc: imx-dsp-rproc: Avoid power on device after probe With multiple power domain case, don't need to use flag DL_FLAG_RPM_ACTIVE when device linking, otherwise the power is always enabled after probe. With DSP's case, the power may increase about 20% for whole system when DSP is enabled wrongly. Fixes: d2634e10d191 ("LF-4209-1: remoteproc: imx_dsp_rproc: add remoteproc driver for dsp") Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> Reviewed-by: Peng Zhang <peng.zhang_8@nxp.com> Acked-by: Jason Liu <jason.hui.liu@nxp.com> --- drivers/remoteproc/imx_dsp_rproc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c index 0e92d4084ec2ea..5b6270aaa055d1 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -846,8 +846,7 @@ static int imx_dsp_attach_pm_domains(struct imx_dsp_rproc *priv) priv->pd_dev_link[i] = device_link_add(dev, priv->pd_dev[i], DL_FLAG_STATELESS | - DL_FLAG_PM_RUNTIME | - DL_FLAG_RPM_ACTIVE); + DL_FLAG_PM_RUNTIME); if (IS_ERR(priv->pd_dev_link[i])) { dev_pm_domain_detach(priv->pd_dev[i], false); ret = PTR_ERR(priv->pd_dev_link[i]); -- GitLab