From 8694d6100de0f80e0bdb9f8ec6dfa7a40dbc451e Mon Sep 17 00:00:00 2001
From: Fancy Fang <chen.fang@nxp.com>
Date: Thu, 4 Apr 2019 17:19:23 +0800
Subject: [PATCH] MLK-21383 drm/bridge: sec-dsim: fix maybe-uninitialized build
 warnings
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

If enable CONFIG_DYNAMIC_DEBUG, below maybe-uninitialized build
warnings happen:

"
In file included from ./include/linux/printk.h:336:0,
                 from ./include/linux/kernel.h:14,
                 from ./include/linux/unaligned/access_ok.h:5,
                 from ./include/asm-generic/unaligned.h:13,
                 from ./arch/arm64/include/generated/asm/unaligned.h:1,
                 from drivers/gpu/drm/bridge/sec-dsim.c:17:
drivers/gpu/drm/bridge/sec-dsim.c: In function ‘sec_mipi_dsim_calc_pmsk’:
./include/linux/dynamic_debug.h:135:3: warning: ‘best_s’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   __dynamic_dev_dbg(&descriptor, dev, fmt, \
   ^
drivers/gpu/drm/bridge/sec-dsim.c:1149:27: note: ‘best_s’ was declared here
  uint32_t best_p, best_m, best_s;
                           ^
In file included from ./include/linux/printk.h:336:0,
                 from ./include/linux/kernel.h:14,
                 from ./include/linux/unaligned/access_ok.h:5,
                 from ./include/asm-generic/unaligned.h:13,
                 from ./arch/arm64/include/generated/asm/unaligned.h:1,
                 from drivers/gpu/drm/bridge/sec-dsim.c:17:
./include/linux/dynamic_debug.h:135:3: warning: ‘best_m’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   __dynamic_dev_dbg(&descriptor, dev, fmt, \
   ^
drivers/gpu/drm/bridge/sec-dsim.c:1149:19: note: ‘best_m’ was declared here
  uint32_t best_p, best_m, best_s;
                   ^
In file included from ./include/linux/printk.h:336:0,
                 from ./include/linux/kernel.h:14,
                 from ./include/linux/unaligned/access_ok.h:5,
                 from ./include/asm-generic/unaligned.h:13,
                 from ./arch/arm64/include/generated/asm/unaligned.h:1,
                 from drivers/gpu/drm/bridge/sec-dsim.c:17:
./include/linux/dynamic_debug.h:135:3: warning: ‘best_p’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   __dynamic_dev_dbg(&descriptor, dev, fmt, \
   ^
drivers/gpu/drm/bridge/sec-dsim.c:1149:11: note: ‘best_p’ was declared here
  uint32_t best_p, best_m, best_s;
           ^
"

Although this is a spurious warning according to the code logic, it
is better to give 'best_p', 'best_m' and 'best_s' initial values to
suppress the warnings.

Reported-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Fancy Fang <chen.fang@nxp.com>
---
 drivers/gpu/drm/bridge/sec-dsim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/sec-dsim.c b/drivers/gpu/drm/bridge/sec-dsim.c
index 51bfc47b90cfe6..2e4c17d9d603db 100644
--- a/drivers/gpu/drm/bridge/sec-dsim.c
+++ b/drivers/gpu/drm/bridge/sec-dsim.c
@@ -1146,7 +1146,7 @@ static void sec_mipi_dsim_set_standby(struct sec_mipi_dsim *dsim,
 struct dsim_pll_pms *sec_mipi_dsim_calc_pmsk(struct sec_mipi_dsim *dsim)
 {
 	uint32_t p, m, s;
-	uint32_t best_p, best_m, best_s;
+	uint32_t best_p = 0, best_m = 0, best_s = 0;
 	uint32_t fin, fout;
 	uint32_t s_pow_2, raw_s;
 	uint64_t mfin, pfvco, pfout, psfout;
-- 
GitLab